openhatch

Issue240

Title Snapshots should (but currently do not) include people's public tags
Milestone 0.11.05 Priority wish
Waiting On Status resolved
Superseder Snapshots should (but currently do not) include TrackerModel and TrackerQueryModel instances
View: 391
Nosy List Lorthirk, jessica, palhmbs, paulproteus
Assigned To paulproteus Keywords bitesize

Created on 2011-01-28.23:33:31 by paulproteus, last changed 2011-05-05.16:03:51 by paulproteus.

Files
File name Uploaded Type Edit Remove
0001-Snapshot-exporter-now-exports-tags-for-users-and-tag.patch Lorthirk, 2011-05-04.17:53:31 text/x-patch
Messages
msg1832 (view) Author: paulproteus Date: 2011-05-05.16:03:50
Hi Lorthirk!

Some small bits of feedback, on things you could improve:

* When I look in "git log -p", I see that you removed the newline at the end of
the snapshot_public_data.py file. We've been leaving the last character of the
file as the '\n' character.

* It would be nice if you left a comment in the snapshot_public_data.py file
about why it's safe to export *all* the tags. It looks a little suspicious to
export all of them without a comment (although I agree that it's correct).

* Total nitpick: Usually we write comments as "# comment" not "#comment" (notice
the space character).

None of these are show-stoppers, since the patch passes its tests and looks
good. Good work! Pushing.
msg1830 (view) Author: Lorthirk Date: 2011-05-04.17:53:31
Added back the updated patch. Now it's ready to be reviewed.
msg1822 (view) Author: Lorthirk Date: 2011-05-04.09:47:52
I removed the patch and put back the status to in-progress since I had an idea 
about a small improvement of the test, which I hope to write down this evening.
msg1821 (view) Author: Lorthirk Date: 2011-05-03.21:17:31
Patch attached, with the implementation + update of test_snapshot_person.
msg1812 (view) Author: Lorthirk Date: 2011-05-02.08:52:54
I'm writing the test case now. Once this is done, issue 391 can be taken care of 
(since they share the same code, and this is near to being closed, I think it's 
best to close this before starting 391).
msg1793 (view) Author: paulproteus Date: 2011-05-01.09:12:57
Quietly bumping toward 0.11.05, gently.
msg1731 (view) Author: Lorthirk Date: 2011-04-24.22:51:52
snapshot_public_data.py now exports tags, tagtypes and tags_person_links correctly, 
but an exception is being raised now in bug exporting (I suspect, due to no rows 
present for table search_bugtracker in database). Test is still to be written.
msg1643 (view) Author: paulproteus Date: 2011-04-20.06:37:54
Jessica, adding you to nosy.

You were looking for bitesize-esque things to do. This one is maybe
mouthful-size, but if you already know Django, it shouldn't be too crazy hard.
Feel free to assign it to yourself and/or remove yourself from nosy.
msg1568 (view) Author: paulproteus Date: 2011-04-16.21:46:29
If you like backend-type Python work, this is a good first bug to look at.

People's "tags" are the self-labeled text people add to themselves, like at
https://openhatch.org/people/paulproteus/ the "can pitch in with" text.

We store these attached to a Person using the Link_Person_Tag model and the Tag
and TagType model. You can find those in mysite/profile/models.py.

We create data snapshots -- see
https://openhatch.org/wiki/Importing_a_data_snapshot for more information about
them. These nightly shapshots are helpful for developers to work on the
OpenHatch code.

The problem is that the snapshots don't include these "Tag" objects, nor the
"Link_Person_Tag" objects that tie the tags to a person. These tags are public
information

mysite/customs/management/commands/snapshot_public_data.py is where the code
lives that does the snapshotting.

The point of this bug is so that the snapshot that we generate, with
snapshot_public_data, includes all instances of Link_Person_Tag, and any Tag
objects that requires.

Long description -- but it's actually reasonably easy. When you submit it, you
should submit it with an automated test that verifies it works -- see "class
DataExport" in mysite/customs/tests.py to see how to write one.

As always, we are available to help you work on this! Join us on #openhatch or
just ask on this ticket.
msg845 (view) Author: paulproteus Date: 2011-01-28.23:33:31
Right now, the snapshots don't export people's tags. That's a shame.
History
Date User Action Args
2011-05-05 16:03:51paulproteusunlinkissue391 blockers
2011-05-05 16:03:51paulproteussetstatus: need-review -> resolved
messages: + msg1832
2011-05-04 17:53:31Lorthirksetstatus: in-progress -> need-review
assignedto: Lorthirk -> paulproteus
messages: + msg1830
files: + 0001-Snapshot-exporter-now-exports-tags-for-users-and-tag.patch
2011-05-04 09:47:53Lorthirksetstatus: need-review -> in-progress
assignedto: paulproteus -> Lorthirk
messages: + msg1822
2011-05-04 09:47:09Lorthirksetfiles: - 0001-Snapshot-exporter-now-exports-tags-for-users-and-tag.patch
2011-05-03 21:17:50Lorthirksetassignedto: Lorthirk -> paulproteus
2011-05-03 21:17:32Lorthirksetstatus: in-progress -> need-review
files: + 0001-Snapshot-exporter-now-exports-tags-for-users-and-tag.patch
messages: + msg1821
2011-05-02 08:52:54Lorthirksetsuperseder: + Snapshots should (but currently do not) include TrackerModel and TrackerQueryModel instances
messages: + msg1812
2011-05-02 08:49:11Lorthirklinkissue391 blockers
2011-05-01 09:12:57paulproteussetmessages: + msg1793
milestone: 0.11.04 -> 0.11.05
2011-04-24 22:51:56Lorthirksetmessages: - msg1729
2011-04-24 22:51:53Lorthirksetmessages: + msg1731
2011-04-24 22:32:12Lorthirksetstatus: chatting -> in-progress
assignedto: Lorthirk
messages: + msg1729
nosy: + Lorthirk
2011-04-20 06:37:54paulproteussetnosy: + jessica
messages: + msg1643
2011-04-19 09:37:25palhmbssetnosy: + palhmbs
2011-04-16 21:46:29paulproteussetstatus: unread -> chatting
messages: + msg1568
milestone: 0.11.04
2011-01-28 23:33:31paulproteuscreate