openhatch

Issue347

Title confusing wording of [other] contributors total on profile page
Milestone 0.11.06 Priority wish
Waiting On Status resolved
Superseder Nosy List JasonWoof, palhmbs, paulproteus
Assigned To palhmbs Keywords bitesize, usability

Created on 2011-03-24.11:53:02 by JasonWoof, last changed 2011-06-19.22:21:36 by paulproteus.

Files
File name Uploaded Type Edit Remove
0001-fix-ambiguous-wording3.patch palhmbs, 2011-06-06.23:03:19 text/x-diff
0001-fix-contrib3.patch palhmbs, 2011-06-11.22:57:17 text/x-diff
Messages
msg2084 (view) Author: paulproteus Date: 2011-06-19.22:21:35
Thanks, Paul, for the further UI cleanup here!
msg2070 (view) Author: palhmbs Date: 2011-06-11.22:41:26
I didn't like it when 5 contributors are only in a project it shows 1-4 (of 4).

So I've fixed it so that it will only ever show 1-4 (of 5) when there is more
than 5 total contributors, otherwise it'll just show Other Contributors (4):

Please review!
msg2056 (view) Author: paulproteus Date: 2011-06-06.23:07:54
Paul,

Your most recent patch is great! I moved the parentheses around in one case; see
http://gitorious.org/openhatch/oh-mainline/commit/f857ef6c076da1d57e4f7a3fe8aeb0429bcbf4a8

Deployed.
msg2050 (view) Author: palhmbs Date: 2011-06-06.03:28:37
With some help from JasonWoof, I've decided that it's probably easiest to just
subtract the user from the contributor_count.

Although I'd love to include the person in the results for egotistical desires,
it does seem pointless to do so when the person has created the project because
they have contributed to it.

This patch (0001-fixed-confusing-wording2.patch) implements a filter to subtract
1 from contributor_count - it is in the 
mysite/profile/templatetags/profile_extras.py file.
msg2049 (view) Author: palhmbs Date: 2011-06-06.00:58:15
There are now 2 patches, cause I figured I might double my chances to pass the
review!!

The 0001-fixed-confusing-wording.patch just does as JasonWoof suggests, without
including the word total anywhere.

The 0001-fix-amibiguous-wording2.patch doesn't include the user in the total
when it's less than 4.

This probably isn't ideal, as we should just change the backend code to remove
the user from the total.
msg2047 (view) Author: palhmbs Date: 2011-06-06.00:11:58
Ok, done!

I put in some if statements for the less than 4 and greater than 4 options.

I believe that if we did decide to remove the user from the contributor total it
would be done with the functions in...  mysite/search/models.py and
mysite/profile/templatetags/profile_extras.py
msg2005 (view) Author: paulproteus Date: 2011-06-02.13:05:34
This is getting somewhere, but I don't think it's at the perfect point yet.

When I go to http://openhatch.org/people/paulproteus/ , I see one project with a
total of 2 people. Just 1 is shown, because the other person is me. It says "2
total", which is confusing.

I think that so far, I like JasonWoof's suggested changes the most. paulhmbs,
would you be willing to implement things that way instead?
msg2000 (view) Author: palhmbs Date: 2011-06-02.00:51:33
Should we just change ( # total) to ( # ) - If so, then try this patch out.
msg1771 (view) Author: palhmbs Date: 2011-04-30.23:05:36
This just didn't happen this milestone, let's make sure it does in 11.05!!
msg1569 (view) Author: paulproteus Date: 2011-04-16.21:48:15
This is a confusing user interface issue, which is the topic of 0.11.04.

It would be great to see this resolved in April.
msg1335 (view) Author: JasonWoof Date: 2011-03-24.11:53:01
On my profile page: http://openhatch.org/people/JasonWoof/ by each project it 
says 
something like "Other contributors (3 total):" then shows two people. I see the 
ambiguity, but to me it looks like it's saying that there are 3 (total) other 
contributors, where in fact there are three including me (not all other.)

I suggest changing the wording so it is more clear.

For projects with more than 4 contributors, headline "Contributors 1-4 of 25:" 
and 
the link read "show all".

For projects with 4 or less: headline "Contributors:" link "show on map".

I'm undecided about whether (in the case of >4 contributors) if the logged in 
user 
should be filtered out. Pros: it shows more info that the user doesn't know 
(showing 4 instead of 3 others.) Cons: but I like seeing my head next to projects 
I 
care about.

Thanks for thinking about this, and hopefully tweaking the site.

You guys are awesome. Fantastic site, making the world a better place, and very 
friendly and helpful responses on IRC even when I bring something that should 
have 
gone directly into a bug report.

Take care,    - Jason
History
Date User Action Args
2011-06-19 22:21:36paulproteussetstatus: need-review -> resolved
messages: + msg2084
2011-06-11 22:57:17palhmbssetfiles: + 0001-fix-contrib3.patch
2011-06-11 22:56:56palhmbssetfiles: - 0001-fix-contrib2.patch
2011-06-11 22:48:09palhmbssetfiles: + 0001-fix-contrib2.patch
2011-06-11 22:47:57palhmbssetfiles: - 0001-fix-contrib2.patch
2011-06-11 22:41:27palhmbssetstatus: resolved -> need-review
files: + 0001-fix-contrib2.patch
messages: + msg2070
2011-06-06 23:07:54paulproteussetstatus: need-review -> resolved
messages: + msg2056
2011-06-06 23:03:19palhmbssetfiles: + 0001-fix-ambiguous-wording3.patch
2011-06-06 23:00:58palhmbssetfiles: - 0001-fix-ambiguous-wording2.patch
2011-06-06 23:00:51palhmbssetfiles: - 0001-fixed-confusing-wording.patch
2011-06-06 23:00:16paulproteussetfiles: - 0001-fixed-confusing-wording2.patch
2011-06-06 03:32:58palhmbssetfiles: + 0001-fixed-confusing-wording2.patch
2011-06-06 03:31:18palhmbssetfiles: - 0001-fixed-confusing-wording2.patch
2011-06-06 03:28:37palhmbssetmessages: + msg2050
2011-06-06 03:24:43palhmbssetfiles: + 0001-fixed-confusing-wording2.patch
2011-06-06 00:58:15palhmbssetmessages: + msg2049
2011-06-06 00:54:34palhmbssetfiles: + 0001-fixed-confusing-wording.patch
2011-06-06 00:54:21palhmbssetfiles: + 0001-fix-ambiguous-wording2.patch
2011-06-06 00:24:19palhmbssetfiles: - 0001-Fix-ambiguous-wording.patch
2011-06-06 00:12:26palhmbssetfiles: - 0001-fixed-confusing-wording.patch
2011-06-06 00:12:08palhmbssetstatus: in-progress -> need-review
2011-06-06 00:11:58palhmbssetfiles: + 0001-Fix-ambiguous-wording.patch
messages: + msg2047
2011-06-02 13:05:35paulproteussetstatus: need-review -> in-progress
messages: + msg2005
2011-06-02 00:51:42palhmbssetstatus: chatting -> need-review
2011-06-02 00:51:33palhmbssetfiles: + 0001-fixed-confusing-wording.patch
assignedto: palhmbs
messages: + msg2000
2011-05-28 21:54:08palhmbssetkeyword: + bitesize, usability
2011-05-28 21:53:47palhmbssetmilestone: 0.11.05 -> 0.11.06
2011-04-30 23:05:36palhmbssetnosy: + palhmbs
messages: + msg1771
milestone: 0.11.04 -> 0.11.05
2011-04-16 21:48:15paulproteussetstatus: unread -> chatting
messages: + msg1569
milestone: later -> 0.11.04
2011-03-24 11:53:02JasonWoofcreate