|
|
Created on 2011-05-02.23:13:56 by 2mas, last changed 2011-05-29.12:40:47 by paulproteus.
| msg1951 (view) |
Author: paulproteus |
Date: 2011-05-29.12:40:46 |
|
In the future, can you write more in the commit log about what you changed?
Also please put the link to the bug tracker on its own line, rather than in the
first line? It gets really long, and then 'git log' gets hard to read.
Other than that, this looks good. Pushing. Thanks for finding it!
|
| msg1948 (view) |
Author: palhmbs |
Date: 2011-05-29.10:24:25 |
|
And here it is.
|
| msg1947 (view) |
Author: palhmbs |
Date: 2011-05-29.10:07:43 |
|
Re-opening this because of a small error in the landing page.
The link for git mission directs to....
https://openhatch.org/missions/git/description
When it should just be...
https://openhatch.org/missions/git
I'll check that the others are uniform at the same time.
|
| msg1890 (view) |
Author: paulproteus |
Date: 2011-05-23.01:02:15 |
|
Hi Paul+Mark,
Sorry I didn't notice this; it was indeed due to the bug state not being
need-review. Mega thanks to Mark for addressing that.
Paul, your patch includes a little more than it needs to. In particular, it
includes UI changes that I want to be a separate commit. I'd prefer if
you'd get someone's sign-off on those UI changes -- maybe you can email
Devel and ask people what they think, with a link to your
I've carefully edited your patch and included only the part that is
relevant to this ticket. Once you 'git rebase origin/master' your local
repository will have a commit that contains the stuff I didn't accept.
(I think that your changes are a good idea, but I think we should discuss
them on-list briefly.)
Deployed! I took a look on the live site, and it looks great.
Also, nearly 20 days is *too* long for a patch to wait. Sorry I let it wait
so long.
|
| msg1876 (view) |
Author: Mark |
Date: 2011-05-21.01:23:30 |
|
It looks like a patch is here. Should this be in needs review status?
|
| msg1866 (view) |
Author: palhmbs |
Date: 2011-05-11.20:59:03 |
|
I've decided that I should just dive on in and create the backend function/s for
the display of mission status.
Trying to make it work without was too much of a headache.
I love the idea of having it like "certain gaming quest trackers" with the
number completed out of a total.
|
| msg1852 (view) |
Author: jessica |
Date: 2011-05-07.23:18:37 |
|
Ok, we can make a new bug that is refactoring the missions and just hardcode for
now. :)
|
| msg1840 (view) |
Author: palhmbs |
Date: 2011-05-07.19:40:46 |
|
A new backend function is too complicated for me at this stage.
|
| msg1828 (view) |
Author: jessica |
Date: 2011-05-04.15:19:31 |
|
I was thinking a new backend function or functions for the display of status. And
for the exact reason pythonian4000 said. It can get really "wordy" with all the
ifs and such.
For example, if we have all the possible missions in a table, we can get a list
of missions. Also, we won't have to update at least two templates when we add a
new mission. Maybe also a way to get current state for the logged in user.
For example, this is just the Mission box on the landing page:
==Learn/Missions== (snag all missions)
* Git: step 2 > (output mission.step and url)
git.info (maybe a little blurb too?)
* Bzr: step 1 >
bzr.info
* SVN: completed
svn.info
OR
==Learn/Missions==
_In Progress_ (snag all missions that are started and not completed or snag all
missions and group by state?)
* Git - step 3 > (output mission.step and url)
* SVN - step 5 >
_Not started_
* Bzr - step 1 >
_Completed_
* Bash
* Diff
OR more like certain gaming quest trackers ;)
==Learn/Missions== (snag all missions)
* Git: 2/5 (steps 2 out of 5 done) (output mission.step and number of steps and
url)
* SVN: 0/3 (hasn't started)
|
| msg1823 (view) |
Author: pythonian4000 |
Date: 2011-05-04.13:52:00 |
|
This might just be me, but I think the patch ends up a bit wordy. I think it is
because you end up with the same text ("You have completed...") repeated over
and over. Rather than doing this, maybe the "Completed missions" header could be
left, and an "Unfinished missions" header could also be added (and maybe a "New
missions" header (though the word "New" implies recent. Maybe "Unstarted", or
something similar?)).
On a more technical note, the patch applies fine and I get the changed text, but
the ticks don't appear. Although the CSS shows the list-style-image attribute
correctly, FireBug shows the two lines being concatenated to
list-style: disc inside url("http://openhatch.org/static/images/tick.gif");
and changing it in Firebug to what it actually is in the CSS file doesn't make
the ticks appear.
|
| msg1819 (view) |
Author: palhmbs |
Date: 2011-05-03.08:46:06 |
|
I've added the Git mission to the logged_in_landing page.
I have also created tick boxes for completed or crosses for not.
ie, jledbetter's comment @ issue322 :
"Mission status if in progress should be 11.05 (unless someone can do that cause
I'm out of time).
To do that I've used the code from...
oh-mainline/mysite/missions/templates/missions/main.html
Please review!
|
| msg1816 (view) |
Author: 2mas |
Date: 2011-05-02.23:13:55 |
|
On the index page, once you've completed a mission it is listed under the 'Training
Missions' section. The git mission hasn't been added to this?
|
|
| Date |
User |
Action |
Args |
| 2011-05-29 12:40:47 | paulproteus | set | status: need-review -> resolved messages:
+ msg1951 |
| 2011-05-29 10:24:34 | palhmbs | set | status: reopened -> need-review |
| 2011-05-29 10:24:25 | palhmbs | set | files:
+ 0001-Small-fix.patch messages:
+ msg1948 |
| 2011-05-29 10:07:43 | palhmbs | set | status: resolved -> reopened messages:
+ msg1947 |
| 2011-05-23 01:02:16 | paulproteus | set | status: need-review -> resolved messages:
+ msg1890 |
| 2011-05-21 12:03:04 | Mark | set | status: in-progress -> need-review |
| 2011-05-21 01:24:10 | Mark | set | nosy:
+ Mark |
| 2011-05-21 01:23:31 | Mark | set | messages:
+ msg1876 |
| 2011-05-11 20:59:04 | palhmbs | set | messages:
+ msg1866 |
| 2011-05-08 08:25:48 | palhmbs | set | assignedto: palhmbs |
| 2011-05-07 23:18:38 | jessica | set | messages:
+ msg1852 |
| 2011-05-07 19:40:47 | palhmbs | set | assignedto: palhmbs -> (no value) messages:
+ msg1840 |
| 2011-05-04 15:19:31 | jessica | set | nosy:
+ jessica messages:
+ msg1828 |
| 2011-05-04 13:53:04 | pythonian4000 | set | nosy:
+ pythonian4000 |
| 2011-05-04 13:52:01 | pythonian4000 | set | status: need-review -> in-progress messages:
+ msg1823 |
| 2011-05-03 08:49:53 | palhmbs | set | status: resolved -> need-review |
| 2011-05-03 08:48:43 | palhmbs | set | files:
+ 0001-Git-for-Landing.patch |
| 2011-05-03 08:48:26 | palhmbs | set | files:
- 0001-Git-for-Landing.patch |
| 2011-05-03 08:46:06 | palhmbs | set | status: unread -> resolved files:
+ 0001-Git-for-Landing.patch nosy:
+ palhmbs messages:
+ msg1819 assignedto: palhmbs milestone: 0.11.05 |
| 2011-05-02 23:13:56 | 2mas | create | |
|